omit enable-auth and enable-route annotations for ServingRuntime when disabled #2037
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #2050
Description
enable-auth
andenable-route
are not used by kserve. Therefore it's a bit odd to seeenable-route: 'false'
and have kserve create a route.This change simply omits these annotations altogether unless their values are set to
'true'
.How Has This Been Tested?
ServingRuntime
for theenable-auth
andenable-route
annotations to not be present.ServingRuntime
for theenable-auth
andenable-route
annotations to not be present.ServingRuntime
for theenable-auth
andenable-route
annotations to have values'true'
.Test Impact
New unit tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
main